feat(visual-editing): add svelte optimistic state support #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
stipsan
force-pushed
the
feat/optimistic-svelte
branch
from
2bf847a to
633bf18
Compare
stipsan
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
I've refactored the deprecation markings to follow the same approach we use for marking:
import createClient from '@sanity/client' // tsdoc says you should migrate to `import {createClient} from '@sanity/client'`in @sanity/client.
Do the changes to exports make sense?
Yep!
Does the Svelte useOptimistic implementation follow the existing React logic OK?
And yep! Let's go!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optimistic state support for Svelte via the
useOptimisticexport in@sanity/visual-editing/svelte.I've also re-worked a lot of the existing optimistic related exports, and added a new
@sanity/visual-editing/optimisticexport path which exposes the non-framework specific parts needed for e.g. Nuxt to implement this functionality.Going forward we should recommend that the React version of
useOptimisticbe imported from@sanity/visual-editing/reactrather than the root@sanity/visual-editingexport path. I've added that export to the React specific path but haven't removed anything from that root path for now, so no breaking changes. I'm not sure how we can mark the root exports specifically as deprecated with TSDoc, open to ideas there!So the two big things to review are:
useOptimisticimplementation follow the existing React logic OK?